Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Module FFmpegKitReactNativeModule requires main queue setup since it overrides init but doesn't implement requiresMainQueueSetup. #199

Closed
manuelbieh opened this issue Oct 22, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request fixed-in-v4.5.1 react-native Affect react-native platform v4.5 Affects v4.5 release

Comments

@manuelbieh
Copy link

manuelbieh commented Oct 22, 2021

Description
Hey. I just installed and set up ffmpeg-kit for my brand new React Native app and once I start the app I get a warning:

Module FFmpegKitReactNativeModule requires main queue setup since it overrides `init` but doesn't 
implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all 
native modules on a background thread unless explicitly opted-out of

Expected behavior
There should be no warning

Current behavior
There is a warning

To Reproduce

npx react-native init TestApp
yarn add ffmpeg-kit-react-native

set platform :ios, '12.1' in ios/Podfile

npx pod-install

add import { FFmpegKit, ReturnCode } from 'ffmpeg-kit-react-native'; to any file (e.g. App.js)
build and run the app

Screenshots
image

Logs

BUNDLE  ./index.js 

WARN  Module FFmpegKitReactNativeModule requires main queue setup since it overrides `init` but doesn't 
implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all 
native modules on a background thread unless explicitly opted-out of.

Environment

  • Platform: iOS
  • Architecture: arm64 m1 macbook air
  • Version 4.5
  • Source branch (if applicable) v4.5 release from npm
  • React Native 0.65.1
  • Xcode version (if applicable) 15
  • Cocoapods version (if applicable) 1.11.2

Other
Via Google I found other libs with the same bug (and also a possible 4 lines fix, see: facebook/react-native#24314)

@tanersener
Copy link
Collaborator

I don't know why but we don't have this issue in our test apps under the ffmpeg-kit-test repo.

Anyway, I'll mark this as enhancement and address before the next release.

@tanersener tanersener added enhancement New feature or request react-native Affect react-native platform v4.5 Affects v4.5 release labels Oct 22, 2021
@tanersener tanersener added this to Needs triage in Next GA Release via automation Oct 22, 2021
@tanersener tanersener self-assigned this Oct 22, 2021
@tanersener tanersener moved this from Needs triage to Closed in Next GA Release Oct 22, 2021
@tanersener tanersener added the fixed-on-development Fixed on the development branch. Not released yet. label Oct 22, 2021
@manuelbieh
Copy link
Author

I will try to remove all the project relevant stuff from my repo and create a new repo where the error can (hopefully) be reproduced tomorrow.

@tanersener
Copy link
Collaborator

You don't need to. I've already seen it in a new project and fixed it on the development-react-native branch.

I just don't know why we haven't seen it on our apps. It seems like it is not a new warning/check coming with the latest react-native versions; it was already there for a few years.

@arthenica arthenica deleted a comment from github-actions bot Dec 23, 2021
@tanersener tanersener added fixed-in-v4.5.1 and removed fixed-on-development Fixed on the development branch. Not released yet. labels Jan 2, 2022
@tanersener
Copy link
Collaborator

Fixed in v4.5.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed-in-v4.5.1 react-native Affect react-native platform v4.5 Affects v4.5 release
Projects
No open projects
Next GA Release
  
Closed
Development

No branches or pull requests

2 participants