Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Algorithms #31

Closed
wants to merge 2 commits into from
Closed

New Algorithms #31

wants to merge 2 commits into from

Conversation

jtesta
Copy link

@jtesta jtesta commented Oct 11, 2017

I've implemented support for new algorithms. Some of them are described in RFC4344, RFC4250, and RFC4432, and others are implemented in somewhat obscure SSH libraries.

FYI, the changes made to output_algorithm() are needed to suppress empty "[info]" comments for some of the new algorithms (for example: "(key) ssh-rsa-sha256@ssh.com -- [info] ").

@codecov
Copy link

codecov bot commented Oct 11, 2017

Codecov Report

Merging #31 into develop will decrease coverage by 0.13%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
- Coverage    97.41%   97.27%   -0.14%     
===========================================
  Files            1        1              
  Lines         1430     1433       +3     
===========================================
+ Hits          1393     1394       +1     
- Misses          37       39       +2
Impacted Files Coverage Δ
ssh-audit.py 97.27% <57.14%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8eb46d...a3f126a. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 11, 2017

Coverage Status

Coverage decreased (-0.1%) to 97.278% when pulling 1bb5490 on jtesta:new_algs into d8eb46d on arthepsy:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 97.278% when pulling 1bb5490 on jtesta:new_algs into d8eb46d on arthepsy:develop.

@coveralls
Copy link

coveralls commented Oct 11, 2017

Coverage Status

Coverage decreased (-0.1%) to 97.28% when pulling a3f126a on jtesta:new_algs into d8eb46d on arthepsy:develop.

2 similar comments
@coveralls
Copy link

coveralls commented Oct 11, 2017

Coverage Status

Coverage decreased (-0.1%) to 97.28% when pulling a3f126a on jtesta:new_algs into d8eb46d on arthepsy:develop.

@coveralls
Copy link

coveralls commented Oct 11, 2017

Coverage Status

Coverage decreased (-0.1%) to 97.28% when pulling a3f126a on jtesta:new_algs into d8eb46d on arthepsy:develop.

@jtesta
Copy link
Author

jtesta commented Nov 27, 2017

Hi.. will you merge these back upstream? #thx/bye ; )

Paging @arthepsy ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants