Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 : BaseSettings has been moved to pydantic-settings #32

Merged
merged 1 commit into from
Jul 18, 2023
Merged

🐛 : BaseSettings has been moved to pydantic-settings #32

merged 1 commit into from
Jul 18, 2023

Conversation

thomas-rooty
Copy link
Contributor

Updated import in settings.py since BaseSettings has been moved to pydantic-settings

@arthuRHD
Copy link
Owner

I missed out on this change, thanks!
But since it's a new dependency, we should consider adding it inside the setup.py file.

@arthuRHD arthuRHD added the bug Something isn't working label Jul 18, 2023
@arthuRHD
Copy link
Owner

I missed out on this change, thanks! But since it's a new dependency, we should consider adding it inside the setup.py file.

I've added it inside #33. This is working.

@arthuRHD arthuRHD changed the title BaseSettings has been moved to pydantic-settings 🐛 : BaseSettings has been moved to pydantic-settings Jul 18, 2023
@arthuRHD arthuRHD merged commit 84e0cc6 into arthuRHD:master Jul 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthuRHD arthuRHD arthuRHD approved these changes

Assignees

@thomas-rooty thomas-rooty

Labels
bug Something isn't working
Projects
immosheets backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomas-rooty @arthuRHD