Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Azure support and a bit of refactoring #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

idanlevin
Copy link

@arthur-c two important notes:

  1. The S3 usage here is deprecated and needs to be removed (I added a TODO there)
  2. There is one breaking change I couldn't avoid with creating the TLS secrets, since I wanted to be able to use helm install <chart> --set-file key=/path/to/file and couldn't have done it without adding b64enc

- "--grpc-server-tls-client-ca=/thanos-tls-server/ca.crt"
{{- end }}
{{- end }}
{{- if .Values.objectStorageConfig.enabled }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might solve #10

@camprr
Copy link

camprr commented Dec 5, 2019

I'd love to implement this based on the following article (https://itnext.io/monitoring-kubernetes-workloads-with-prometheus-and-thanos-4ddb394b32c) , any news on this being merged?

@arthur-c
Copy link
Owner

arthur-c commented Dec 5, 2019

Hello @camprr , currently I don't have the time to include PRs in this project, but this chart has been forked many times and some forks are more active and advanced than this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants