Skip to content
This repository has been archived by the owner on Feb 17, 2019. It is now read-only.

Refactoring + Analysis tools #8

Closed
2 of 6 tasks
arthurazs opened this issue Oct 27, 2016 · 4 comments
Closed
2 of 6 tasks

Refactoring + Analysis tools #8

arthurazs opened this issue Oct 27, 2016 · 4 comments
Labels
feature
Projects
Refactoring

Comments

@arthurazs
Copy link
Owner

arthurazs commented Oct 27, 2016 •
edited
Loading

Create one issue for each of the following:
@arthurazs arthurazs added this to the v1.5 milestone Oct 27, 2016
@arthurazs arthurazs self-assigned this Oct 27, 2016
@arthurazs arthurazs mentioned this issue Oct 27, 2016
Closed
@arthurazs arthurazs changed the title Refactoring + Integration Refactoring + Analysis tools Oct 27, 2016
@arthurazs arthurazs removed their assignment Oct 28, 2016
@arthurazs arthurazs modified the milestones: v1.5, v1.4, GitHub Improvement Oct 31, 2016
@arthurazs
Copy link
Owner Author

arthurazs commented Oct 31, 2016 •
edited
Loading

Search more refactoring/analysis tools!

Maybe this can help.

@arthurazs
Copy link
Owner Author

arthurazs commented Nov 2, 2016 •
edited
Loading

See tox

DONE

Using tox: ab8cc31 !

arthurazs pushed a commit that referenced this issue Nov 3, 2016
Refactoring 'data.py'
5f16316 
Pointing CONSTANTS to the Class instead of to a Object.
All file handlers methods turned into functions (static methods).
Improved the following methods:
 - sort(dictionary) -> sort(hero_tuple)
 - checkDname(self, name) -> prepare_d_name(line)
 - checkHurl(self, name) -> prepare_h_url(h_url)
 - checkItem(self, name) -> prepare_item(key)
 - checkAbility(self, text) -> prepare_ability(line)
 - prepare_name(cls, value) -> prepare_line(line)

See #8
arthurazs pushed a commit that referenced this issue Nov 5, 2016
Renamed 'parser' to 'dotapatch'
eeac38f 
See #8
@arthurazs
Copy link
Owner Author

arthurazs commented Nov 6, 2016 •
edited
Loading

TODO

Make dota2 the default tempalte.

Rename default to gh-pages.

DONE

@arthurazs
Copy link
Owner Author

arthurazs commented Nov 7, 2016 •
edited
Loading

WARNING

$ dotapatch 688s bugging, check it out

DONE

not bugging

@arthurazs arthurazs moved this from TODO to Done in Refactoring Dec 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature
Projects
No open projects
Refactoring
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arthurazs