Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: provide internationalization support #63

Open
tsaarni opened this issue Feb 5, 2024 · 2 comments · May be fixed by #64
Open

Feature: provide internationalization support #63

tsaarni opened this issue Feb 5, 2024 · 2 comments · May be fixed by #64

Comments

@tsaarni
Copy link

tsaarni commented Feb 5, 2024

Feature request: add support for internationalization in nss-pam-ldapd.

Since the PAM module has interactions with the user, it would be useful to allow internationalization for the prompt strings. This would also allow administrator to change the strings e.g. remove details that the password is LDAP password in prompt such as

nss-pam-ldapd/pam/pam.c

Lines 730 to 731 in 33cf91c

rc = pam_get_authtok(pamh, PAM_OLDAUTHTOK, (const char **)&oldpassword,
"(current) LDAP Password: ");

@tsaarni
Copy link
Author

tsaarni commented Feb 5, 2024

Would the project be interested in contribution if I created a PR?

@arthurdejong
Copy link
Owner

Hi @tsaarni,

Thanks for your suggestion. A PR for this would be very welcome. I don't know about the limitations of using gettext in a PAM module. Also, this should be an optional requirement since the software is used on a lot of different platforms (FreeBSD, Solaris, etc.).

I'm pretty short on spare time for a while now so while I try to keep up with pull requests and incoming queries I can't give you a guarantee on responsiveness.

Kind regards,

@tsaarni tsaarni linked a pull request Mar 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants