Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): apply id on label's htmlFor attribute #284

Merged
merged 1 commit into from
May 28, 2020

Conversation

arthurdenner
Copy link
Owner

What kind of change does this PR introduce?
Bug fix.

What is the current behavior?
When provided, the id prop is not applied on the label's htmlFor attribute.

What is the new behavior?
The id is applied and therefore, the label is now accessible.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@arthurdenner arthurdenner added the bug Something isn't working label May 28, 2020
@vercel
Copy link

vercel bot commented May 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/36r7z4hqt
✅ Preview: In Progress

(e744b8b, update in progress)

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #284 into develop will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #284      +/-   ##
===========================================
+ Coverage    87.11%   87.33%   +0.21%     
===========================================
  Files           14       14              
  Lines          458      458              
  Branches        92       92              
===========================================
+ Hits           399      400       +1     
  Misses          56       56              
+ Partials         3        2       -1     
Impacted Files Coverage Δ
src/components/input.tsx 100.00% <100.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3a7e3e...e744b8b. Read the comment docs.

@arthurdenner arthurdenner merged commit 4d9ffb1 into develop May 28, 2020
@arthurdenner
Copy link
Owner Author

🎉 This PR is included in version 2.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arthurdenner arthurdenner deleted the fix/accessible-label branch November 9, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant