Skip to content

fix(datepicker): apply id on label's htmlFor attribute #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2020
Merged

fix(datepicker): apply id on label's htmlFor attribute #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/__tests__/datepicker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,16 @@ describe('Basic datepicker', () => {
expect(datePickerInput.value).toBe('');
});

it('should be accessible when id is provided', () => {
const { getByLabelText, getByText } = setup({
id: 'click-me',
label: 'Click me',
});

fireEvent.click(getByLabelText('Click me'));
expect(getByText('Today')).toBeTruthy();
});

describe('clearOnSameDateClick', () => {
it('reset its state when prop is true', () => {
const { datePickerInput, getByText, openDatePicker } = setup({
Expand Down
2 changes: 1 addition & 1 deletion src/components/input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const CustomInput = React.forwardRef<Input, InputProps>((props, ref) => {

return (
<Form.Field>
{label && <label>{label}</label>}
{label && <label htmlFor={rest.id as string | undefined}>{label}</label>}
<Input
data-testid="datepicker-input"
{...rest}
Expand Down