fix locale import for esm #664
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/2987w7Z1XWpkW4jmUCYcsSKVgZAz |
| @@ -17,6 +17,7 @@ import { BasicDatePicker, RangeDatePicker } from './pickers'; | |||
| import { Locale, SemanticDatepickerProps } from './types'; | |||
| import Calendar from './components/calendar'; | |||
| import Input from './components/input'; | |||
| import localeOptions from "./locales"; | |||
There was a problem hiding this comment.
Correct me if I'm wrong but this would bundle all of the locales into the project, and we don't want to do that.
There was a problem hiding this comment.
You are correct that it does includes all locales. This is quickest (but not ideal) solution to make this work without needing to refactor a lot of code to accommodate dynamic import. Please feel free to close the PR and go with one of the options @wollo suggested in the issue.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
What kind of change does this PR introduce?
This PR fixes the locale import issue for esm js file.
What is the current behavior?
see issue #176
What is the new behavior?
The fix will replace the
requiremodule with native ESimport.Checklist: