fix: correct lowercase test

arthurfiorette · Jun 8, 2023 · 7e5ca7e · 7e5ca7e
1 parent e189b72
commit 7e5ca7e
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 15 deletions.
diff --git a/package.json b/package.json
@@ -65,7 +65,7 @@
     "@typescript-eslint/eslint-plugin": "^5.50.0",
     "@typescript-eslint/parser": "^5.50.0",
     "auto-changelog": "^2.4.0",
-    "axios": "^1.3.1",
+    "axios": "^1.4.0",
     "es-check": "^7.0.0",
     "eslint": "^8.33.0",
     "eslint-config-prettier": "^8.3.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/util/cache-predicate.ts b/src/util/cache-predicate.ts
@@ -24,10 +24,7 @@ export async function testCachePredicate<R = unknown, D = unknown>(
     for (const [header, predicate] of Object.entries(containsHeaders)) {
       if (
         !(await predicate(
-          // Axios response headers are in lowercase, but check both just in case.
-
-          // FIXME: https://github.com/axios/axios/pull/5525
-          // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
+          // Avoid bugs in case the header is not in lower case
           response.headers[header.toLowerCase()] ?? response.headers[header]
         ))
       ) {

diff --git a/test/util/cache-predicate.test.ts b/test/util/cache-predicate.test.ts
@@ -45,23 +45,25 @@ describe('tests cache predicate object', () => {
       headers: { 'content-type': 'application/json' }
     });
 
+    expect(await testCachePredicate(response, {})).toBeTruthy();
+
     expect(
       await testCachePredicate(response, {
-        containsHeaders: { 'content-type': () => true }
+        containsHeaders: { 'content-type': () => false }
       })
-    ).toBeTruthy();
+    ).toBeFalsy();
 
     expect(
       await testCachePredicate(response, {
-        containsHeaders: { 'Content-Type': () => true }
+        containsHeaders: { 'Content-Type': () => false }
       })
-    ).toBeTruthy();
+    ).toBeFalsy();
 
     expect(
       await testCachePredicate(response, {
-        containsHeaders: { 'Content-Type': () => true }
+        containsHeaders: { 'Content-Type': () => false }
       })
-    ).toBeTruthy();
+    ).toBeFalsy();
   });
 
   it('tests containsHeader', async () => {