Handle infinite loading states when a restart occurs in the middle of a request.

[arthurfiorette]

When using any kind of persisted storage, the app may restart while a request is in loading waiting for it to finish. In this case, the request will arrive here:

axios-cache-interceptor/src/interceptors/request.ts

Lines 168 to 178 in b731b2c

	/* istanbul ignore if 'really hard to test' */
	if (!deferred) {
	await axios.storage.remove(id, config);
	// Hydrates any UI temporarily, if cache is available
	if (cache.data) {
	await config.cache.hydrate?.(cache);
	}
	return config;
	}

Which is when we have a loading state but no deferred is registered (as it is a in memory promise hash map). Previously we just deleted the cache and continued with a empty response to be handled by the response interceptor.

If the response of this request comes successful, it would ignore caching and return here:

axios-cache-interceptor/src/interceptors/response.ts

Lines 99 to 107 in b731b2c

	if (
	// If the request interceptor had a problem or it wasn't cached
	cache.state !== 'loading'
	) {
	if (__ACI_DEV__) {
	axios.debug?.({
	id,
	msg: "Response not cached and storage isn't loading",
	data: { cache, response }

Or, if this response failed, it would re-throw the error thinking the interceptor broke:

axios-cache-interceptor/src/interceptors/response.ts

Lines 270 to 280 in b731b2c

	if (
	// This will only not be loading if the interceptor broke
	cache.state !== 'loading' ||
	cache.previous !== 'stale'
	) {
	await rejectResponse(id, config);
	if (__ACI_DEV__) {
	axios.debug?.({
	id,
	msg: 'Caught an error in the request interceptor',

The responses interceptors are right to expect a loading state, otherwise non loading requests should've been resolved from the request interceptor already.

To solve this problem, the check below must be done in the ignoreAndRequest code block to fix the cache to loading before returning the response.

axios-cache-interceptor/src/interceptors/request.ts

Lines 164 to 165 in b731b2c

	if (cache.state === 'loading') {
	const deferred = axios.waiting[id];