Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: memory storage copy data to avoid reference changes #164

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

arthurfiorette
Copy link
Owner

@arthurfiorette arthurfiorette commented Mar 7, 2022

Closes #163.

@arthurfiorette arthurfiorette added the bug Something isn't working label Mar 7, 2022
@arthurfiorette arthurfiorette self-assigned this Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #164 (762d08b) into main (bb88a8b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          495       511   +16     
  Branches       145       146    +1     
=========================================
+ Hits           495       511   +16     
Impacted Files Coverage Δ
src/header/interpreter.ts 100.00% <ø> (ø)
src/storage/memory.ts 100.00% <100.00%> (ø)
src/util/update-cache.ts 100.00% <100.00%> (ø)
test/storage/storages.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb88a8b...762d08b. Read the comment docs.

@arthurfiorette arthurfiorette merged commit f699e19 into main Mar 11, 2022
@arthurfiorette arthurfiorette deleted the gh/fix-163 branch March 11, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data value vanish after first cached value read access
1 participant