fix: Prevent response storage calls if method is not supported #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #464 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 507 516 +9
Branches 155 159 +4
=========================================
+ Hits 507 516 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Awesome!! Can you add a test case for it? |
I added tests for fulfill and my new change regarding reject. Please feel free to point out any needed changes. :) |
arthurfiorette
requested changes
Jan 17, 2023
|
Thank you so much for your catch... I'll release ASAIC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems plugin performs a
storage.getcall when getting response from requests that do not meet the method criteria (e.g. method POST).By following the same principle in request interceptor, we make sure response does not make unnecessary calls.