Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[must-revalidate] properly revalidate based on eTag #824

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

edwinveldhuizen
Copy link
Contributor

@edwinveldhuizen edwinveldhuizen commented Apr 22, 2024

Fixes #822 and by fixing #507 in a different fashion

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (e9d05ed) to head (039da87).
Report is 9 commits behind head on main.

❗ Current head 039da87 differs from pull request most recent head 2916549. Consider uploading reports for the commit 2916549 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   99.29%   99.26%   -0.03%     
==========================================
  Files          19       19              
  Lines        2400     2449      +49     
  Branches      211      214       +3     
==========================================
+ Hits         2383     2431      +48     
- Misses         16       17       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/storage/build.ts Outdated Show resolved Hide resolved
@arthurfiorette
Copy link
Owner

thanks!

@arthurfiorette arthurfiorette merged commit 6cba59c into arthurfiorette:main Apr 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants