-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Week numbers #54
Week numbers #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! ❤️
} else { | ||
" ".to_string() | ||
}; | ||
rows[row_counter][column_counter][line] = padding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be write using format!
macro, its more eficient
); | ||
|
||
if week_numbers { | ||
(0..rows[row_counter][column_counter].len()).for_each(|line| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll refactor further it to casual for loop, its more idiomatic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably could shift it into month_printable
Just realised I introduced a bug; the current date is off by 1. Looking into it now... |
Implements/closes #41.