Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacktoberfest 2022 #1

Closed
arthurits opened this issue Oct 1, 2022 · 14 comments
Closed

Hacktoberfest 2022 #1

arthurits opened this issue Oct 1, 2022 · 14 comments
Labels
good first issue Good for newcomers Hacktoberfest Hacktoberfest 2023

Comments

@arthurits
Copy link
Owner

arthurits commented Oct 1, 2022

This repo is participating in Hacktoberfest 2022!

Translations are welcome as a way to enter Hacktoberfest 2022.

Contributions

We are looking for contributions to translate this project's string resources (strings.resx, 186 strings) into any of the 24 official languages in the EU:

  • Bulgarian
  • Croatian
  • Czech
  • Danish
  • Dutch (both nl-BE and nl-NL)
  • English
  • Estonian
  • Finnish
  • French
  • German
  • Greek
  • Hungarian
  • Irish
  • Italian
  • Latvian
  • Lithuanian
  • Maltese
  • Polish
  • Portuguese (both pt-PT and pt-BR)
  • Romanian
  • Slovak
  • Slovenian
  • Spanish
  • Swedish

Other languages might be accepted (but not granted) upon personal consideration.

Please note that BanglaBangla (bn-BD), Czech Czech, DanishDanish (da-DK), Dutch Belgium Dutch (nl-BE), EnglishEnglish, FrenchFrench, GermanGerman, ItalianItalian, RussiaRussian, SlovakSlovak, Spanish Spanish, Turkey Turkish (tr-TR), and Chinese Simplified Chinese (zh-Hans) are already covered.

Instructions

Create a new PR by adding a new file in the project's localization folder named strings.xx-XX.resx, where xx-XX stands for the chosen language; i.e.: de-DE for German, fr-FR for French, et cetera. The new file should contain all the string resources from the base strings.resx translated into the chosen language.

Some of the string resources include string formatters and other characters (ampersands, line breaks, et cetera) that should be respected in order for the PR to be accepted.

Approval

Please wait until your PR is reviewed, validated, merged and labelled with hacktoberfest-accepted before it is recognised in your Hacktoberfest profile.

@arthurits arthurits added the Hacktoberfest Hacktoberfest 2023 label Oct 1, 2022
@SvA1
Copy link
Contributor

SvA1 commented Oct 3, 2022

I could help you out with the German translation.

@Xav83
Copy link
Contributor

Xav83 commented Oct 3, 2022

Hi @arthurits,

I have created a created a Pull Request regarding the french translation (PR #4), and, on my Hacktoberfest profile, this Pull Request has been tagged as NOT-PARTICIPATING.

Screenshot from 2022-10-03 21-51-39

@arthurits
Copy link
Owner Author

I have created a created a Pull Request regarding the french translation (PR #4), and, on my Hacktoberfest profile, this Pull Request has been tagged as NOT-PARTICIPATING.

Hi @Xav83,
I believe contributors have to wait untill the PR is merged, approved, and tagged as accepted.

I've just reviewed your PR and all should be right in a short period of time. Should there be any problems regarding this issue, please don't hesitate to let me know.

Merci beaucoup pour votre contribution!

@arthurits
Copy link
Owner Author

arthurits commented Oct 4, 2022

I could help you out with the German translation.

@SvA1, I'm really happy for your contribution. Vielen Dank!

@sarequl
Copy link
Contributor

sarequl commented Oct 4, 2022

Can I translate this to Bangla (Bn)?

@arthurits
Copy link
Owner Author

arthurits commented Oct 4, 2022

Can I translate this to Bangla (Bn)?

Hi @sarequl!

Sure! I would rather prefer Hindi but Bangla is also OK. Please keep in mind what I told you previoulsy.
Many of the strings in both projects are the same, so this will make your work easier (keep in mind that both translations should be consistent).

Thanks so much for your interest!

@fadkeabhi
Copy link

May I work on hindi translations

@arthurits
Copy link
Owner Author

arthurits commented Oct 4, 2022

May I work on hindi translations

Sure @fadkeabhi! I would be very glad if you could! 🙂
Hindi translation is also needed here.

@Pyr0x1
Copy link
Contributor

Pyr0x1 commented Oct 5, 2022

Hello, I can work on the italian translation if not taken yet

@arthurits
Copy link
Owner Author

Hi @Pyr0x1, nobody is working on the Italian translation.

@fadkeabhi
Copy link

fadkeabhi commented Oct 5, 2022

May I work on hindi translations

Sure @fadkeabhi! I would be very glad if you could! 🙂 Hindi translation is also needed here.

I am done with hindi translations. and made a PR here arthurits/SignalAnalysis#6 . please approve with hacktoberfest-accepted label.

@Pyr0x1
Copy link
Contributor

Pyr0x1 commented Oct 6, 2022

One note, the PRs aren't recognized as participating in Hacktoberfest (unless you mark them with the hacktoberfest-accepted label), I think the label linked to the project must be hacktoberfest and not hacktoberfest-2022 to make PRs automatically detected as partecipating.

@arthurits
Copy link
Owner Author

One note, the PRs aren't recognized as participating in Hacktoberfest (unless you mark them with the hacktoberfest-accepted label)

That's true. I believe the idea is that only approved and merged PRs, which are labelled as hacktoberfest-accepted, do participate in Hacktoberfest. But that's not automatic, since maintainers have to validate PRs to check whether they qualify for Hacktoberfest or not. So, unless mistaken, that label is the last step in the process and has to be added by the maintainer.

I think the label linked to the project must be hacktoberfest and not hacktoberfest-2022 to make PRs automatically detected as partecipating.

That's a good point, so I've just added that label at the project level to avoid any unexpected issues. However, after reading the Hacktoberfest validation guide I don't believe there's any automatic detection, unless PRs are merged and labelled as hacktoberfest-accepted.

Please let me know if there's any misunderstanding on my side. Also, don't hesitate to let me know if any of your two contributions (here and here) aren't recognised correctly.

I really appreciate your positive feedback!

@Pyr0x1
Copy link
Contributor

Pyr0x1 commented Oct 6, 2022

One note, the PRs aren't recognized as participating in Hacktoberfest (unless you mark them with the hacktoberfest-accepted label)

That's true. I believe the idea is that only approved and merged PRs, which are labelled as hacktoberfest-accepted, do participate in Hacktoberfest. But that's not automatic, since maintainers have to validate PRs to check whether they qualify for Hacktoberfest or not. So, unless mistaken, that label is the last step in the process and has to be added by the maintainer.

I think the label linked to the project must be hacktoberfest and not hacktoberfest-2022 to make PRs automatically detected as partecipating.

That's a good point, so I've just added that label at the project level to avoid any unexpected issues. However, after reading the Hacktoberfest validation guide I don't believe there's any automatic detection, unless PRs are merged and labelled as hacktoberfest-accepted.

Please let me know if there's any misunderstanding on my side. Also, don't hesitate to let me know if any of your two contributions (here and here) aren't recognised correctly.

I really appreciate your positive feedback!

No problem 😁 the PR were recognized correctly, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest Hacktoberfest 2023
Projects
None yet
Development

No branches or pull requests

6 participants