Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for reading the internal temperature probe (second attempt 馃槄) #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

k8ieone
Copy link

@k8ieone k8ieone commented Apr 2, 2022

Same as #77 except without the rouge file.

@bartowl
Copy link

bartowl commented Sep 6, 2022

This PR is really interestiung. Sadly if a device does not report TemSen by default, this PR causes the process to crash:

0|HVAC_0  | [MQTT] Connected to broker
0|HVAC_0  | [UDP] Connected to device at 192.168.2.10
0|HVAC_0  | [UDP] New device registered: 1edd6ca6
0|HVAC_0  | [UDP] Device 1edd6ca6 is bound!
0|HVAC_0  | TypeError: Cannot read properties of undefined (reading 'toString')
0|HVAC_0  |     at Object.onStatus (/usr/src/app/index.js:77:145)
0|HVAC_0  |     at Device._handleResponse (/usr/src/app/app/deviceFactory.js:171:20)
0|HVAC_0  |     at Socket.<anonymous> (/usr/src/app/app/deviceFactory.js:45:47)
0|HVAC_0  |     at Socket.emit (node:events:527:28)
0|HVAC_0  |     at UDP.onMessage [as onmessage] (node:dgram:922:8)

On those devices one needs to explicitely ASK for TemSen to get the readout, so this should be implemented rather in a way, if TemSen is not included, then ask for it interactively and publish only when received...
See: https://github.com/tomikaa87/gree-remote#getting-the-current-temperature-reading-from-the-internal-sensor

@k8ieone
Copy link
Author

k8ieone commented Sep 6, 2022

Ouch, I was wondering what would happen on a device that doesn't report it. Now I know 馃槄

Honestly tho, I'm not a JS developer by a long shot and my "solution" is hacky and as your teating reveals, unfinished.

If anyone's interested in doing this a different/better way, please feel free to do so. I don't have much time on my hands at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants