This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
19 use fmtlib #20
Merged
19 use fmtlib #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start refactoring printf and friends to fmtlib Fix formatting Remove lingering null termination code Add libfmt-dev to Travis libfmt-dev doesn't exist on xenial; so install it manually Remove extraneous keyword
|
Thanks for the PR!
Yes, but don't worry. I'll continue your work later.
Sorry for that. I overlooked this. Might be because I use mostly just one editor for programming in my computers. Also, thanks for fixing the build failures of this pull request. I appreciate the effort you had to do a good job. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fmtlib and also starts the refactoring process. I went a little further but decided to stop here because it's a little tedious:
sprintfis) need to be replaced withmemory_buffer.So I'm opening this PR to get the ball rolling.