Skip to content

Commit

Permalink
See we use rack on the service.rb file, we need to declare the dep
Browse files Browse the repository at this point in the history
  • Loading branch information
arthurnn committed Jan 6, 2023
1 parent 9d5b4b5 commit aa4000f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion twirp.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '>= 1.9'
spec.add_runtime_dependency 'google-protobuf', '~> 3.0', '>= 3.7.0'
spec.add_runtime_dependency 'faraday', '< 3' # for clients
spec.add_dependency 'rack', '>= 2.2.3' # for service server handling

spec.add_development_dependency 'bundler', '~> 2'
spec.add_development_dependency 'minitest', '>= 5'
spec.add_development_dependency 'rake'
spec.add_development_dependency 'rack', '>= 2.2.3'

end

1 comment on commit aa4000f

@dpep
Copy link

@dpep dpep commented on aa4000f Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this fix - it's currently blocking my upgrade of this gem

An error occurred while loading spec_helper. - Did you mean?
                    rspec ./spec/spec_helper.rb

Failure/Error: require "twirp"

LoadError:
  cannot load such file -- rack/request
# /gems/twirp-1.10.0/lib/twirp/service.rb:17:in `require'
# /gems/ruby-3.1.2/gems/twirp-1.10.0/lib/twirp/service.rb:17:in `<top (required)>'

any chance we could publish this fix in twirp 1.10.1 ?

Please sign in to comment.