Actualize code generation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test GDevelop state (https://github.com/4ian/GDevelop/blob/master/newIDE/app/src/EventsFunctionsExtensionsLoader/index.js) with no manual edits. Revert previous backward-compatibility change in EventsFunctionsExtensionsLoader/index.js
|
I'm mostly done with the rewrite :) I'll merge and publish this in the meantime, but don't put much effort in making other PRs since it'll all be replaced soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tough one. I suggest not touching "legacy" implementation of ./src/EventsFunctionsExtensionsLoader/index.js (moved to ./src/EventsFunctionsExtensionsLoader/legacy.js in its original state) to work with GDevelop up to v5.1.149 inclusive.
So there will be no need to support a bunch of backward-compatibility if-else logic enlarging diff with GDevelop latest.
With these changes the Platformer game sample is exported without out-of-memory error and works as expected.
Meanwhile, the idea of
is the right direction to go.