Argument Parser migration #14
Conversation
elfenlaid
force-pushed
the
argument-parser
branch
from
7da9a23
to
3bd789e
Compare
|
Whoa, it's a complete mess by now I've tried to keep the core logic intact as much as possible. Though, there are few minor differences in the error reporting. Now both CLIs are functional with a given priority to swift run -Xswiftc -DARGUMENT_PARSER badgy@arthurpalves would you mind to have a quick glance and decide whether the changes should be served in a more atomic way? |
elfenlaid
changed the title
Sources/Badgy/Commands/Badgy.swift
Outdated
| @OptionGroup() | ||
| var options: Badgy.Options | ||
|
|
||
| @Option(help: "Rotation angle of the badge") |
There was a problem hiding this comment.
In Degrees? Radians? Percent of a full rotation? What's the default if it's not specified?
There was a problem hiding this comment.
You're totally right.
I wonder whether the same should be done to color and tintColor 🤔
Thank you so much for the thorough review! :) |
specify default position value extract valid positions
restore bottomLeft default position for `small` list supported positions list in help
|
What a party! 💯 |
| @Option(default: .bottom, help: "Position on which to place the badge. Supported positions: \(Position.longLabelPositions.formatted())") | ||
| var position: Position | ||
|
|
||
| @Option(default: 0, help: "The rotation angle of the badge in degrees range of -180 ... 180") |
There was a problem hiding this comment.
Does it behave any different with negative values than SwiftCLI?
I've recently seen an issue with it for not really testing before.
Only acceptable when escaped and within single or double quotes
--angle '\-15'
There was a problem hiding this comment.
oh, good catch, haven't thought about it before
There was a problem hiding this comment.
Seems like a common problem for CLIs :)
Yet, as a workaround: ArgumentParser handles negative values if = is used. Example: --angle=-15
Related:
apple/swift-argument-parser#31
apple/swift-argument-parser#153
A first drafts for arguments parser adoption. The meat is somewhere between the first fifty lines of Badgy.swift.
Though, it's a far from done. Just sharing an initial draft and thoughts around it.