Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SwiftCLI Task with Bash command #20

Closed

Conversation

tthbalazs
Copy link

I quickly replaced the Task command from SwiftCLI with Bash. The API is similar but not exactly the same, there is no differentiation between captured / not captured output.

It also does not do async output at the moment, and I'm wondering if the sync one is correct at all 馃

Anyway, it should be easy to build on top of this

@arthurpalves
Copy link
Owner

I was checking this and there is a huge decrease in performance, of about 920%+ 馃

Command

time swift run badgy long XYZ ~/Desktop/TestIcon.appiconset/ \
--color '#DDE4E9' --tint-color '#222222' --angle 15 --replace

Results

master (Pure SwiftCLI)

real	0m7.592s
user	0m8.788s
sys	0m1.090s

rc-argument-parser (ArgumentParser + SwiftCLI.Task)

real	0m7.875s
user	0m8.858s
sys	0m1.080s

tthbalazs:add-bash-command (ArgumentParser + Bash)

real	1m10.434s
user	0m43.044s
sys	0m22.991s

For this reason alone I think we can't merge this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants