Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion sometimes works only partly #43

Closed
Daniel-Mietchen opened this issue Jan 13, 2019 · 4 comments
Closed

Conversion sometimes works only partly #43

Daniel-Mietchen opened this issue Jan 13, 2019 · 4 comments

Comments

@Daniel-Mietchen
Copy link
Contributor

e.g. https://tools.wmflabs.org/author-disambiguator/?name=Ph.+Schwemling&doit=Look+for+author&limit=50&filter=wdt%3AP2093+%22Ph.+Schwemling%22
resulted in just one item being edited, despite 50 having been marked.

@arthurpsmith
Copy link
Owner

Whoah, that's broken. Looking into it now!

@arthurpsmith
Copy link
Owner

Ok, the problem is again coming from the wikidata API - it's not responding or somehow failing to create the entries for most (all but one in this case!) of the manuscripts. I'm relying on that to do the Quickstatements conversion. Hmmm...

@arthurpsmith
Copy link
Owner

Hmm, thought had a fix for this, but I had to roll it back. Still looking into it...

@arthurpsmith
Copy link
Owner

Issue was slight difference in PHP versions (a syntax line that worked locally did not work on wmflabs tools). This is fixed! The new code should be faster in some circumstances (if many of the papers had a large number of authors), but it may be slower in others (for a lot of articles with few authors). I've tested a bit and I think it's acceptable, but maybe some hybrid would be best in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants