Add required step param to OpenthermNumber to prevent error on HA restart #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ov1d1u
changed the title
ov1d1u
changed the title
|
Tested this and it fixes an important bug for me, now I no longer need to remove and add back the integration when HA or the ESP device restarts for whatever reasons. |
Open
Import NotRequired from typing
Fix for negative values encoded in f8.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14. According to this, it looks like ESPHome
numbercomponents are required to define astepfield. I'm not familiar with ESPHome custom components development, so I'm not sure if it was needed to addstepin so many places.