Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blinking in windows terminal #86

Closed
aaleino opened this issue May 2, 2021 · 3 comments
Closed

Blinking in windows terminal #86

aaleino opened this issue May 2, 2021 · 3 comments

Comments

@aaleino
Copy link

aaleino commented May 2, 2021

Thank you for the library. I use WSL and windows terminal. In this terminal, many of the examples blink excessively. For example:

issue

I think that this issue could be avoided by updating only the characters that have changed between frames. Unless this is already the case? It could also lead to better performance in other terminals. I suspect that using std::cout for the drawing might be slow. Although I haven't tested its performance compared to other standard methods.
ArthurSonzogni added a commit that referenced this issue May 16, 2021
@ArthurSonzogni
Remove flickering.
95e31ab 
For some reason, ResetPosition() was also clearing the content. On very
slow terminal emulator like the one on Windows, flickering was visible.

This fixes:
#86
ArthurSonzogni added a commit that referenced this issue May 16, 2021
@ArthurSonzogni
Remove flickering.
755f1ad 
For some reason, ResetPosition() was also clearing the content. On very
slow terminal emulator like the one on Windows, flickering was visible.

This fixes:
#86
@ArthurSonzogni
Copy link
Owner

@aaleino I believe I fixed the issue.
Could you please try on Windows to confirm?

@aaleino
Copy link
Author

aaleino commented May 16, 2021

The flicker is gone. Thanks!

@ArthurSonzogni
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArthurSonzogni @aaleino