Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw03 ready for grading #4

Open
arthursunbao opened this issue Oct 3, 2017 · 3 comments
Open

hw03 ready for grading #4

arthursunbao opened this issue Oct 3, 2017 · 3 comments

Comments

@arthursunbao
Copy link
Owner

@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho

@tom-hc-park
Copy link
Collaborator

tom-hc-park commented Oct 5, 2017

Hello, I am Hyeongcheol Park. Thank you for your inviting me on your GitHub.

To sum up, your GitHub homework is amazing. I am really impressive by how you organize things with more skills than we learned in the class. You solved 6 questions all, with multiple plots on each question!

I learned new codings from your work. It seems you know more than the class takes. library(ggthemes), library(reshape) and free using of “knitr::opts_chunk$set(fig.width=8, fig.height=5)” intrigued me to learn those more. Moreover, you know how to draw histogram well on Q1. I was keep using line graphs, but I realized histogram would be better idea for the question.

On Q2, your summarizing by summary for each continent was impressive. I couldn’t do it so I just used group_by + summarize for every statistics. and about graphs, you cared details on plots, such as name of x and y axis with labs, titles ,theme, and scale and it made the graphs very good looking!

And about Q3, your using of functions such as funs(), and summarise_each() was new to me so interesting.

Especially, on Q6, your managing skills for data with different scales was helpful to me! you used scale() which I didn’t know, so I multiplied 10^3 on age with my Q6, which was same with you; Kuwait’s lifeExp and gdpPercap.

So overall, I learned many new codings and got some brilliant ideas from peer-reviewing your assignment! Thanks for that.

For my last comment, If I should give you some suggestion for your homework even though I actually could not find some considerable flaws, I would say that I fond some error. On Q1, your sentence was put into the first table. I guess you can use:(br /)- use <> instead of () bracket- or preventing your lines go into some tables or plots. And just one more thing, on question 4 after first graph for Asia, there is a typo. you pot America instead of Asia on the sentence, ‘America starts from about 44 to 66 overall.’

To sum up, it was very nice work. your homework contained new coding a lot! I enjoyed exploring your GitHub. Thank you and I hope you keep enjoy learning!

@vibudh2209
Copy link
Collaborator

Hi

Your work is very impressive and every question is efficiently solved (Superb work!!!)

  • Completed atleast 3 tasks (Done all!!!)
  • Repo is very easy to go through and very well organised
  • Link provided for home work in both hw03 readme as well as homepage readme
  • Proper graphs accompanied with tables
  • I want to do more not attempted (Its alright as optional)
  • Process report has been provided (what was easy and what was hard)

Few Comments

  • In question one both min and max gdp found efficiently as well as plot looks good
  • Just a comment here that while using ggplot you can directly write the name of the variable instead of using "$" sign
  • I got to learn labelling max or min gdp in the histogram (Looks great)
  • Gdp per capita visualized and tabulated properly. Just one suggestion that for the graph as there are so many indices you could have used histogram instead and also could have shown everything together in a facet wrap!!!
  • Trimmed mean tabulated and visualized very clearly!!!
  • Finding countries with lifeExp below a threshold done very efficiently. Just a suggestion instead plotting number try plotting percentage that gives a better picture
  • Interesting story question approached wonderfully with proper explanation to your result.
  • You can try explaining what you are doing beforehand each question this way it will be easier to read the code for a new person (just a suggestion!!!)

Over all your work was amazing and there are just so many things to learn from it (your efficient use of ggplot and much more).
Its a check plus from me for sure

Cheers
Vibudh

@pgonzaleze
Copy link

Arthursunbao
At least three tasks: Yes
A table and figure for each task: Yes
Comments on tables/figures: Yes
Reflections on Process: Yes
Bonus (side-by-side layout, new table packages): Yes (partially)

Excellent work, I liked how clean and well explained is each point. I found interesting the analysis that you did because you used the resources taught in class but also you made more exploration and shaping the data.
Finally, I just have to say that your reflections is accurate not only for making graphs but also for any question that you want to tackle!

Your marks will be distributed later!
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants