Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw04 ready for grading #5

Open
arthursunbao opened this issue Oct 10, 2017 · 4 comments
Open

hw04 ready for grading #5

arthursunbao opened this issue Oct 10, 2017 · 4 comments

Comments

@arthursunbao
Copy link
Owner

No description provided.

@arthursunbao
Copy link
Owner Author

@arthursunbao arthursunbao changed the title hw03 ready for grading hw04 ready for grading Oct 12, 2017
@swynes
Copy link
Collaborator

swynes commented Oct 13, 2017

Hi Arthur,

Great work on the homework. I like how everything is well organized, including the readme with the instructions for this day's homework.

Minor positive notes
Your tidyr cheatsheet is concise, showing how to do spread and gather.

I like how you explained what a tibble was and the benefits of using them before making one. I think that really follows the spirit of the homework where this can then become a good resource for you to rely on later.

Minor areas for improvement
On Question 3 you say you're distracting the main life expectancy - did you mean extract?

On Question 7 where we were supposed to join a new dataset to gapminder, you say that you would add capital cities, but I don't see the city capitals in any of the tables produced by any of the joins. The only additional information added that I can find is country codes in one of the tables.

Overall
You definitely go above and beyond the expectations, covering seven different questions. It's very clear that overall you have very good command of the skills needed to be successful with tidyr

Enjoy the rest of the course!

@nicolehawe
Copy link

Hey Jason,

Wow you did so much work! Great job on homework #4! Your repo was very organized and you made the homework with multiple files very easy to navigate. I thought overall you showed that you really understand the purpose of the functions explored in this assignment. I also really appreciated that you took the time to extensively explain each join. I think that this not only makes this assignment a great reference for you in the future but I felt as though it helped me solidify each join too. Some minor areas for improvement I think would be for some cleaner more professional looking tables, potentially exploring kable. Your tables produced have the information, but they sometimes just look cluttered and are difficult to read. Also in Question 6, I had some trouble following what you were doing. I believe you wanted to add capital cities for the countries but I didn't actually see that ever shown in your tables? However overall I think this was a solid effort, and great job exploring so many tasks.

Cheers,
Nicole

@pgonzaleze
Copy link

Hi @arthursunbao here a few comments about your homework:
General data reshaping and relationship to aggregation: Yes
Join, merge, look up: Yes
Progress report: Yes
Extras (optional; merge/match): Yes
Great homework!

  • Its clear that you did not fin so much difficulties in this assignment,
  • I appreciate all the links that you made, that makes easier to read your homework,
  • My only comment for future work would be that in your explanations of “join_functions” try to also mention which is x and y, some readers could find it confuse if they are not familiar with this. For example: which column appears/disappears and why,
  • About coding style that makes it easier to read try to indent after using %>%.

Your marks will be distributed later,

regards,

Pedro G

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants