[API] Change the argument in TaxonFilter service definition

arti0090 · Apr 16, 2021 · 889f37d · 889f37d
1 parent ad98b6c
commit 889f37d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/src/Sylius/Bundle/ApiBundle/Filter/TaxonFilter.php b/src/Sylius/Bundle/ApiBundle/Filter/TaxonFilter.php
@@ -28,12 +28,10 @@ final class TaxonFilter extends AbstractContextAwareFilter
     /** @var IriConverterInterface */
     private $iriConverter;
 
-    /** @var ManagerRegistry */
-    protected $managerRegistry;
-
-    public function __construct(IriConverterInterface $iriConverter, ManagerRegistry $managerRegistry)
+    public function __construct(ManagerRegistry $managerRegistry, IriConverterInterface $iriConverter)
     {
         parent::__construct($managerRegistry);
+
         $this->iriConverter = $iriConverter;
     }
 

diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/services/filters.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/services/filters.xml
@@ -41,8 +41,8 @@
         </service>
 
         <service id="sylius.api.product_taxon_filter" class="Sylius\Bundle\ApiBundle\Filter\TaxonFilter">
+            <argument type="service" id="doctrine" />
             <argument type="service" id="api_platform.iri_converter" />
-            <argument type="service" id="Doctrine\Common\Persistence\ManagerRegistry" />
             <tag name="api_platform.filter" />
         </service>
 

diff --git a/src/Sylius/Bundle/ApiBundle/spec/Filter/TaxonFilterSpec.php b/src/Sylius/Bundle/ApiBundle/spec/Filter/TaxonFilterSpec.php
@@ -22,9 +22,9 @@
 
 final class TaxonFilterSpec extends ObjectBehavior
 {
-    function let(IriConverterInterface $iriConverter, ManagerRegistry $managerRegistry): void
+    function let(ManagerRegistry $managerRegistry, IriConverterInterface $iriConverter): void
     {
-        $this->beConstructedWith($iriConverter, $managerRegistry);
+        $this->beConstructedWith($managerRegistry, $iriConverter);
     }
 
     function it_adds_taxon_filter_if_property_is_product_taxon(