Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time::set_utc doc test uses wrong api #2184

Closed
lopopolo opened this issue Sep 20, 2022 · 1 comment · Fixed by #2190
Closed

Time::set_utc doc test uses wrong api #2184

lopopolo opened this issue Sep 20, 2022 · 1 comment · Fixed by #2190
Labels
A-ruby-core Area: Ruby Core types. C-docs Category: Improvements or additions to documentation.

Comments

@lopopolo
Copy link
Member

The doc test calls Time::set_local instead of Time::set_utc.
@lopopolo lopopolo added C-docs Category: Improvements or additions to documentation. A-ruby-core Area: Ruby Core types. labels Sep 20, 2022
@lopopolo
Copy link
Member Author

Subsec fractional examples header is rendered incorrectly, missing a space in the markdown.

Second, minute, hour, day, month use Ruby range syntax instead of Rust range syntax. Use the pattern in day of week docs instead.

lopopolo added a commit that referenced this issue Sep 24, 2022
@lopopolo
Fix spinoso-time tzrs backend doc errors
28a7940 
Fixes #2184.
@lopopolo lopopolo mentioned this issue Sep 24, 2022
Merged
lopopolo added a commit that referenced this issue Sep 24, 2022
@lopopolo
Fix spinoso-time tzrs backend doc errors
d5817e5 
Fixes #2184.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ruby-core Area: Ruby Core types. C-docs Category: Improvements or additions to documentation.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spinoso-time tzrs backend doc errors artichoke/artichoke
1 participant
@lopopolo