Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revendor mruby and re-enable thread test when upstream bug is fixed #24

Closed
lopopolo opened this issue Jul 7, 2019 · 0 comments · Fixed by #178
Closed

Revendor mruby and re-enable thread test when upstream bug is fixed #24

lopopolo opened this issue Jul 7, 2019 · 0 comments · Fixed by #178
Labels
A-deps Area: Source and library dependencies. A-vm Area: Interpreter VM implementations. B-mruby Backend: Implementation of artichoke-core using mruby.

Comments

@lopopolo
Copy link
Member

lopopolo commented Jul 7, 2019

The vendored version of mruby has a bug where in some situations comments do not increment the line number in the parser. This breaks tests which test stack traces. thread.rs has one of these tests that has been disabled. Pull in the upstream bugfix and re-enable the test.

Upstream bug: mruby/mruby#4513

Disabled test:

https://github.com/lopopolo/ferrocarril/blob/329c544006b619b7b4fac9c96b6b5ec51a311a84/mruby/src/extn/core/thread.rs#L155-L194
@lopopolo lopopolo transferred this issue from artichoke/ferrocarril Jul 28, 2019
@lopopolo lopopolo added this to the VM milestone Jul 28, 2019
@lopopolo lopopolo added Backend: mruby A-deps Area: Source and library dependencies. A-vm Area: Interpreter VM implementations. labels Aug 4, 2019
@lopopolo lopopolo removed this from the VM milestone Aug 6, 2019
lopopolo added a commit that referenced this issue Aug 19, 2019
@lopopolo
Reenable thread abort on exception test
f627648 
Fixes GH-24.
@lopopolo lopopolo mentioned this issue Aug 19, 2019
Merged
lopopolo added a commit that referenced this issue Aug 20, 2019
@lopopolo
Reenable thread abort on exception test
aebe0bb 
Fixes GH-24.
lopopolo added a commit that referenced this issue Aug 23, 2019
@lopopolo
Reenable thread abort on exception test
a898e2d 
Fixes GH-24.
@lopopolo lopopolo added the B-mruby Backend: Implementation of artichoke-core using mruby. label Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-deps Area: Source and library dependencies. A-vm Area: Interpreter VM implementations. B-mruby Backend: Implementation of artichoke-core using mruby.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update mruby artichoke/artichoke
1 participant
@lopopolo