Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub Actions workflow that runs the spec-runner under Pernosco #1346

Closed
wants to merge 7 commits into from

Conversation

lopopolo
Copy link
Member

This PR branches from 4321b46 which was known to cause a core dump in #1327.

This PR includes an improved version of the crash.yaml workflow which splits apart the invocations of the spec runner to one per job step and enables recording execution with Pernosco.

cc @rocallahan @khuey

Opening this PR will kick off a run of the crash workflow which I expect to produce a core dump. Once I confirm the Pernosco GitHub Actions integration is working correctly, I'll rebase to the latest trunk and merge this PR.

@lopopolo lopopolo added the A-build Area: CI build infrastructure. label Aug 21, 2021
@lopopolo lopopolo force-pushed the pernosco-integration branch 2 times, most recently from 1722f32 to d5d1b14 Compare August 21, 2021 17:10
@lopopolo lopopolo changed the base branch from trunk to pernosco-integration-base August 21, 2021 17:15
@lopopolo lopopolo changed the base branch from pernosco-integration-base to trunk August 21, 2021 17:19
@lopopolo
Copy link
Member Author

Gah! I don't want to merge trunk in.

@lopopolo
Copy link
Member Author

ok trying again with the latest trunk and reverting 13e4b32.

@lopopolo
Copy link
Member Author

Note: I've been pushing empty commits to trigger rebuilds with unique SHAs as the Pernosco folks iterate on the GitHub Actions integration. I'm engaging with them separately over email.

@lopopolo
Copy link
Member Author

lopopolo commented Aug 29, 2021

Woohoo! The Pernosco integration works!

Here's the debugger shell at the segfault: https://pernos.co/debug/ckckYeQYH_xxvmI4mrZ4dQ/index.html#f{m[O4E,AA_,t[BA,GfU_,f{e[O3o,NUnC_,s{aVbAwlZAA,bOw,uVDZ4,oVFmu___

@lopopolo
Copy link
Member Author

lopopolo commented Sep 6, 2021

workflows won't kick off with conflicts. rebase incoming. this should be the moment of truth.

@lopopolo
Copy link
Member Author

lopopolo commented Sep 6, 2021

pushing a rebase without the cherry pick to make sure the bug still reproduces.

@lopopolo
Copy link
Member Author

lopopolo commented Sep 6, 2021

great! the latest rebase segfaults in GHA: https://github.com/artichoke/artichoke/runs/3528550124?check_suite_focus=true

Pushing up the fix with a cherry-pick to the vendored mruby sources.

@lopopolo lopopolo added the S-do-not-merge Status: This pull request should not be merged. label Sep 7, 2021
lopopolo added a commit that referenced this pull request Sep 18, 2021
Now that the Pernosco integration is known to be working as tested in
the PR #1346, merge the workflow so we can generate reproduction
environments for future crashes.

Pernosco is enabled via environment variable on the runs of the
`spec-runner`.

This commit cherry-picks and squashes a couple of commits from #1346:

- e1eea71
- 91bc825

Closes #1346.
@lopopolo lopopolo deleted the pernosco-integration branch September 18, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: CI build infrastructure. S-do-not-merge Status: This pull request should not be merged.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant