Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cstr from 0.2.9 to 0.2.10 #1710

Merged
merged 2 commits into from
Apr 10, 2022
Merged

Bump cstr from 0.2.9 to 0.2.10 #1710

merged 2 commits into from
Apr 10, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 1, 2022

Bumps cstr from 0.2.9 to 0.2.10.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the A-deps Area: Source and library dependencies. label Mar 1, 2022
@dependabot dependabot bot force-pushed the dependabot/cargo/cstr-0.2.10 branch from b082343 to c48091c Compare March 4, 2022 06:20
@lopopolo
Copy link
Member

lopopolo commented Mar 4, 2022

This dep upgrade is blocked on the upgrade to the Rust 1.59 toolchain, which is itself blocked by a crash in clippy.

cstr 0.2.10 reworks the proc macro to use CStr::from_bytes_with_nul_unchecked which was just recently made const in Rust 1.59.0.

See:

artichoke-backend uses cstr in const contexts but cannot upgrade to Rust 1.59.0 due to rust-lang/rust-clippy#8470.

@dependabot dependabot bot force-pushed the dependabot/cargo/cstr-0.2.10 branch from c48091c to 09cd640 Compare March 8, 2022 17:55
@dependabot dependabot bot force-pushed the dependabot/cargo/cstr-0.2.10 branch 5 times, most recently from 2877d59 to 9dbe610 Compare March 23, 2022 06:25
@lopopolo lopopolo added the S-blocked Status: Marked as blocked ❌ on something else such as other implementation work. label Apr 2, 2022
@lopopolo
Copy link
Member

lopopolo commented Apr 2, 2022

Blocked on upgrading the Rust toolchain:

@dependabot dependabot bot force-pushed the dependabot/cargo/cstr-0.2.10 branch from 9dbe610 to 804bef9 Compare April 2, 2022 05:20
Bumps [cstr](https://github.com/upsuper/cstr) from 0.2.9 to 0.2.10.
- [Release notes](https://github.com/upsuper/cstr/releases)
- [Commits](https://github.com/upsuper/cstr/commits)

---
updated-dependencies:
- dependency-name: cstr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/cstr-0.2.10 branch from 804bef9 to 886e71a Compare April 10, 2022 02:13
@lopopolo lopopolo removed the S-blocked Status: Marked as blocked ❌ on something else such as other implementation work. label Apr 10, 2022
@lopopolo
Copy link
Member

no longer blocked since these are merged:

@lopopolo lopopolo merged commit 914bea3 into trunk Apr 10, 2022
@lopopolo lopopolo deleted the dependabot/cargo/cstr-0.2.10 branch April 10, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-deps Area: Source and library dependencies.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant