Align spinoso-string#make_binary to be more alike the String#b

[b-n]

Fixes #1720

As talked about in the issue, the implementation in spinoso-string can be a little confusing when looking at how it is implemented in artichoke-backend. Specifically, spinoso-string is changing the encoding, however String#b is actually cloning the String before actually changing, so we might as well just do this directly and return a new value.

[lopopolo]

Looks good, I'd love to see one additional assert in the doc tests now that we're cloning the bytes

[b-n]

@lopopolo I believe it's unrelated to this specific change, but am I correct in assuming we can't actually check anything with relation to encoding on the String ruby class? https://github.com/artichoke/artichoke/blob/trunk/artichoke-backend/src/extn/core/string/string.rb#L514

Specifically, trying to test this above change like so:

artichoke 0.1.0-pre.0 (2022-04-02 revision 5484) [x86_64-unknown-linux-gnu]
[rustc 1.58.1 (db9d1b20b 2022-01-20) on x86_64-unknown-linux-gnu]
>>> "a".b.encoding
=> #<Encoding:UTF-8>

^-- not what I was expecting, and dug into String#encode and found that statement.

[lopopolo]

Yea Encoding as a Ruby object isn't exposed from Artichoke right now. The comments in the Ruby stubs appear to be outdated tho.

Artichoke does have an Encoding class, but it is essentially a stub to get Ruby spec to run. It so not wired up to the String internals.

I should file some tickets.

[b-n]

Would you believe that Documentation Workflow error run can't be reproduced locally?

➜  artichoke git:(make-binary-to-binary) rustup -Vv    
rustup 1.24.3 (ce5817a94 2021-05-31)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.58.1 (db9d1b20b 2022-01-20)`
➜  artichoke git:(make-binary-to-binary) rustc -Vv 
rustc 1.58.1 (db9d1b20b 2022-01-20)
binary: rustc
commit-hash: db9d1b20bba1968c1ec1fc49616d4742c1725b4b
commit-date: 2022-01-20
host: x86_64-unknown-linux-gnu
release: 1.58.1
LLVM version: 13.0.0
➜  artichoke git:(make-binary-to-binary) cargo version --verbose       
cargo 1.58.0 (f01b232bc 2022-01-19)
release: 1.58.0
commit-hash: f01b232bc7f4d94f0c4603930a5a96277715eb8c
commit-date: 2022-01-19
host: x86_64-unknown-linux-gnu
libgit2: 1.3.0 (sys:0.13.23 vendored)
libcurl: 7.80.0-DEV (sys:0.4.51+curl-7.80.0 vendored ssl:OpenSSL/1.1.1l)
os: Ubuntu 20.04 (focal) [64-bit]

And cargo +nightly doc --workspace appears to "just work". I see you had some failure of this recently, any tips?

[lopopolo]

Oh sorry I ran into this in #1753 too. The current nightly rust doc has an ICE in spinoso-array. It's fixed in master. I'll run the workflow again tonight when the next nightly is out.

rust-lang/rust#95712 (comment)

[lopopolo]

And cargo +nightly doc --workspace appears to "just work". I see you had some failure of this recently, any tips?

In case you are curious about this and how Artichoke uses nightly Rust, this command uses whatever version of nightly you happen to have installed. The breakage is only on the current nightly though, which you can get by running rustup update nightly.

rake doc and rake fmt:rust will automatically pull down a nightly if you don't have one, but they won't update it.

rake doc uses nightly rust because docs.rs renders docs with nightly and Artichoke makes use of some docsrs attributes which are only available on nightly like feature callouts:

artichoke/artichoke-core/src/lib.rs

Lines 14 to 19 in 19ff1ef

	// Enable feature callouts in generated documentation:
	// https://doc.rust-lang.org/beta/unstable-book/language-features/doc-cfg.html
	//
	// This approach is borrowed from tokio.
	#![cfg_attr(docsrs, feature(doc_cfg))]
	#![cfg_attr(docsrs, feature(doc_alias))]

rake fmt:rust uses nightly because this rustdoc config, which does intellij style import grouping, is nightly only:

artichoke/rustfmt.toml

Lines 14 to 15 in 19ff1ef

	# nightly only option
	group_imports = "StdExternalCrate"

In CI, Artichoke uses nightly for the fuzz workflows because:

• cargo-fuzz requires nightly.
• Using sanitizers like LeakSan requires passing an unstable -Z sanitizer=leak flag to rustc.

In CI, Artichoke uses nightly for the rustdoc workflow and for cargo fmt for the same reasons the Rakefile does.

[lopopolo]

new nightly is out, I rebuilt the docs workflow and build is green. we're ready to merge