Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currently passing specs for Core Time to catch regressions #2068

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

b-n
Copy link
Member

@b-n b-n commented Aug 10, 2022

#1956 Is attempting to change the feature in spinoso-time from chrono to tzrs, however it was hard to test for regressions since the existing chrono crate did actually support some of the MRI specs. This should also make it easier to test for MRI compatibility of the new tzrs feature.

This is the new output with the chrono feature enabled:

...
Time#asctime: N
Time#ceil: NNNNNNN
Time#ctime: N
Time#day: NNN
Time#dst?: N
Time#floor: NNNNN
Time#friday?: NN
Time#getgm: N
Time#getutc: N
Time#hash: NN
Time#hour: NNN
Time#inspect: NNNS
Time#isdst: N
Time#mday: NNN
Time#min: NNN
Time#mon: NNN
Time#monday?: NN
Time#month: NNN
Time#round: NNNNN
Time#saturday?: NN
Time#strftime: 
Time#strftime with %L: 
Time#strftime with %N: 
Time#strftime with %z: 
Time#subsec: NSNNSN
Time#sunday?: NN
Time#thursday?: NN
Time#to_a: N
Time#to_f: .
Time#to_r: SN
Time#to_s: NNNS
Time#tuesday?: NN
Time#tv_nsec: .
Time#tv_usec: .
Time#wednesday?: NN
Time#yday: .N
Time#year: NNN
...

Note: I suspect that the large amount of N here is due to Time#inspect not being implemented, which in turn is throwing this error to the spec runner. In reality, I think these are mostly successful, but it's a bit hard to know for sure at present.

Some of the non related to time specs are currently failing, however those were logged in #2067

It appears that this core class was missed originally, however many of
the specs already pass with the `chrono` feature in spinoso-time.
Changing to the new `tzrs` feature might cause regressions, and this is
the best way to catch them
@b-n b-n added A-ruby-core Area: Ruby Core types. A-spec Area: ruby/spec infrastructure and completeness. B-mruby Backend: Implementation of artichoke-core using mruby. labels Aug 10, 2022
@b-n b-n requested a review from lopopolo August 10, 2022 12:19
@b-n b-n merged commit ff28d46 into trunk Aug 10, 2022
@b-n b-n deleted the b-n/add-time-to-spec-runner branch August 10, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ruby-core Area: Ruby Core types. A-spec Area: ruby/spec infrastructure and completeness. B-mruby Backend: Implementation of artichoke-core using mruby.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants