-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass whether a Regexp
is a /.../
literal from mruby codegen to Artichoke
#2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruby codegen pushes a block to `Regexp::compile`.
This is an in-channel signal from the mruby VM that the regexp was parsed as a literal. See parse.y.
lopopolo
force-pushed
the
lopopolo/regexp-literal
branch
from
August 14, 2022 15:58
e107e0c
to
aab134d
Compare
Required to pass specs and not emit spurious warnings. This is a breaking change to spinoso-regexp because it makes a previously const function non-const.
Tracking the upstreaming to artichoke/mruby the parser and codegen changes from aab134d here: |
lopopolo
added a commit
to artichoke/mruby
that referenced
this pull request
Jan 2, 2023
lopopolo
added a commit
to artichoke/mruby
that referenced
this pull request
Jan 2, 2023
lopopolo
added a commit
to artichoke/mruby
that referenced
this pull request
Jan 2, 2023
lopopolo
added a commit
to artichoke/mruby
that referenced
this pull request
Jan 2, 2023
lopopolo
added a commit
to artichoke/mruby
that referenced
this pull request
Jan 2, 2023
lopopolo
added a commit
to artichoke/mruby
that referenced
this pull request
Jan 2, 2023
lopopolo
added a commit
to artichoke/mruby
that referenced
this pull request
Jan 2, 2023
lopopolo
added a commit
to artichoke/mruby
that referenced
this pull request
Jan 28, 2023
lopopolo
added a commit
to artichoke/mruby
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes:
And the exceptions: