Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec-runner: .txt fixtures are not require/load paths #2097

Merged
merged 1 commit into from
Aug 23, 2022
Merged

spec-runner: .txt fixtures are not require/load paths #2097

merged 1 commit into from
Aug 23, 2022

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Aug 23, 2022 •
edited
Loading

Fixes these fatal errors arising from SyntaxErrors in the ARGF
specs:

fatal: Value receiver for function call is dead. This indicates a bug in the mruby garbage collector. Please leave a comment at https://github.com/artichoke/artichoke/issues/1336.
fatal: Value receiver for function call is dead. This indicates a bug in the mruby garbage collector. Please leave a comment at https://github.com/artichoke/artichoke/issues/1336.
fatal: Value receiver for function call is dead. This indicates a bug in the mruby garbage collector. Please leave a comment at https://github.com/artichoke/artichoke/issues/1336.

Relates to:

@lopopolo lopopolo added A-spec Area: ruby/spec infrastructure and completeness. B-mruby Backend: Implementation of artichoke-core using mruby. labels Aug 23, 2022
@lopopolo lopopolo mentioned this pull request Aug 23, 2022
Open
@lopopolo
Copy link
Member Author

Build failure in clang-format step is due to:

@lopopolo
spec-runner: .txt fixtures are not require/load paths
2669a8d 
Fixes these fatal errors arising from `SyntaxError`s in the `ARGF`
specs:

```
fatal: Value receiver for function call is dead. This indicates a bug in the mruby garbage collector. Please leave a comment at #1336.
fatal: Value receiver for function call is dead. This indicates a bug in the mruby garbage collector. Please leave a comment at #1336.
fatal: Value receiver for function call is dead. This indicates a bug in the mruby garbage collector. Please leave a comment at #1336.
```
@lopopolo lopopolo force-pushed the lopopolo/spec-runner-do-not-load-fixtures branch from e1e479a to 2669a8d Compare August 23, 2022 15:36
@lopopolo lopopolo merged commit 432a490 into trunk Aug 23, 2022
@lopopolo lopopolo deleted the lopopolo/spec-runner-do-not-load-fixtures branch August 23, 2022 16:53
@lopopolo lopopolo mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-spec Area: ruby/spec infrastructure and completeness. B-mruby Backend: Implementation of artichoke-core using mruby.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lopopolo