Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kernel::NOT_SET and Kernel#not_set? #240

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Sep 1, 2019

This API and constant were added in artichoke/ferrocarril#85 to load Sinatra and
work around mruby not supporting expressions as default parameters in method argument
lists.

This patch belongs in nemesis instead of artichoke core.

This API and constant were added in artichoke/ferrocarril#85 to load Sinatra and
work around mruby not supporting expressions as default parameters in method argument
lists.

This patch belongs in nemesis instead of artichoke core.
@lopopolo lopopolo added B-mruby A-ruby-core Area: Ruby Core types. A-spec Area: ruby/spec infrastructure and completeness. labels Sep 1, 2019
@lopopolo
Copy link
Member Author

lopopolo commented Sep 1, 2019

It also appears this behavior changed since the last time I looked. With mruby@artichoke-vendor:

> def foo(bar = (not_set = true)); puts not_set.inspect; end
 => :foo
> foo
true
 => nil
> foo('a')
nil
 => nil

@lopopolo lopopolo merged commit d77cca4 into master Sep 1, 2019
@lopopolo lopopolo deleted the remove-kernel-not-set branch September 1, 2019 17:00
@lopopolo lopopolo added B-mruby Backend: Implementation of artichoke-core using mruby. C-quality Category: Refactoring, cleanup, and quality improvements. labels Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ruby-core Area: Ruby Core types. A-spec Area: ruby/spec infrastructure and completeness. B-mruby Backend: Implementation of artichoke-core using mruby. C-quality Category: Refactoring, cleanup, and quality improvements.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant