Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Args support for month string values #2413

Merged
merged 7 commits into from
Feb 19, 2023
Merged

Time Args support for month string values #2413

merged 7 commits into from
Feb 19, 2023

Commits on Feb 18, 2023

  1. Time Args support for month string values 

    Time#utc, Time#local, and friends all support specifying a month value
from the shortened 3 character english names for the month.

Ref: https://ruby-doc.org/3.1.2/Time.html#method-c-utc
    @b-n
    b-n committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    ddd9316 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Replace escaping with something more sensible

    @b-n
    b-n committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    52cba1c View commit details
    Browse the repository at this point in the history

  2. Add variant test cases for month string support

    @b-n
    b-n committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    863f7ac View commit details
    Browse the repository at this point in the history

  3. Enable use of Kernel#Integer in other areas in rust sources

    @b-n
    b-n committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    7398bb4 View commit details
    Browse the repository at this point in the history

  4. Refactor month logic to be correct to MRI 

    A couple of things I missed is that failure to match on string
conversion results in a call to `Kernel#Integer`, thus the new import.

Additionally, month value matches are now case insensitive and match on
byte strings to avoid addition UTF-8 processing in rust.
    @b-n
    b-n committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    b5088bb View commit details
    Browse the repository at this point in the history

  5. Fix rightwards drift and if/else returning bare types 

    Co-authored-by: Ryan Lopopolo <rjl@hyperbo.la>
    @b-n @lopopolo
    b-n and lopopolo committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    34ab1f1 View commit details
    Browse the repository at this point in the history

  6. Stricter assertation 

    Co-authored-by: Ryan Lopopolo <rjl@hyperbo.la>
    @b-n @lopopolo
    b-n and lopopolo committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    4196689 View commit details
    Browse the repository at this point in the history