Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use short-circuit return instead of Ok wrapping in Time args #2417

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Use short-circuit return instead of Ok wrapping in Time args #2417

merged 2 commits into from
Feb 19, 2023

Conversation

lopopolo
Copy link
Member

Followup to #2413.

@lopopolo lopopolo added A-ruby-core Area: Ruby Core types. C-quality Category: Refactoring, cleanup, and quality improvements. labels Feb 19, 2023
@lopopolo lopopolo requested a review from b-n February 19, 2023 19:50
b-n
b-n approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@b-n b-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

Now I'm wondering if there could ever be a lint rule for this!

@lopopolo lopopolo merged commit 6920b69 into trunk Feb 19, 2023
@lopopolo lopopolo deleted the lopopolo/no-ok-wrap branch February 19, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-n b-n b-n approved these changes

Assignees
No one assigned
Labels
A-ruby-core Area: Ruby Core types. C-quality Category: Refactoring, cleanup, and quality improvements.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopopolo @b-n