Limit downcasing work for String Time month args
#2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopopolo
added
A-ruby-core
b-n
reviewed
Feb 19, 2023
b-n
approved these changes
Feb 19, 2023
All valid string arguments to `Time.new` for the month are 3 ASCII characters. In the event that a very long string is passed, the existing implementation will do a lot of work downcasing the string that is ultimately discarded. Short circuit this by extracting the first 3 bytes from the captured `Vec` and only downcasing those.
lopopolo
force-pushed
the
lopopolo/time-string-month-arg-dos-protection
branch
from
7588248
to
8d91688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All valid string arguments to
Time.newfor the month are 3 ASCII characters. In the event that a very long string is passed, the existing implementation will do a lot of work downcasing the string that is ultimately discarded.Short circuit this by extracting the first 3 bytes from the captured
Vecand only downcasing those.Followup to #2413.