-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Abbrev module #409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Abbrev tests from Ruby stdlib docs | ||
// https://ruby-doc.org/stdlib-2.6.3/libdoc/abbrev/rdoc/Abbrev.html | ||
#[cfg(test)] | ||
mod tests { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 these are excellent thank you.
@@ -217,6 +217,7 @@ def inspect | |||
runner.register(Spec.new('library', 'monitor')) | |||
runner.register(Spec.new('library', 'stringscanner')) | |||
runner.register(Spec.new('library', 'uri')) | |||
runner.register(Spec.new('library', 'abbrev')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this list is alphabetized
@zaccari since issue GH-74 was written, there have been some changes to the Artichoke build pipeline to enable codegen for pure Ruby stdlib packages from upstream Ruby. URI uses this pipeline today: artichoke/artichoke-backend/src/extn/stdlib/mod.rs Lines 25 to 29 in 24aa683
The rest of the existing stdlib ports in Artichoke exist mostly as legacy from the artichoke/ferrocarril#85 days. Moving forward, I'd like stdlib implementations to use this build pipeline if possible. Artichoke maintains a fork of Ruby 2.6.3 that we push fixes to to make these stdlib packages work with the Artichoke and mruby Runtime :https://github.com/artichoke/ruby |
Closes #74
This PR implements the Abbrev module in Rust.