Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Abbrev module #409

Merged
merged 5 commits into from
Dec 8, 2019
Merged

Conversation

zaccari
Copy link
Contributor

@zaccari zaccari commented Dec 6, 2019

Closes #74

This PR implements the Abbrev module in Rust.

Copy link
Member

@lopopolo lopopolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zaccari thanks for the PR. This looks great and thanks for executing so well on GH-74. This PR looks good to merge. I'll leave some comments in the ticket how to approach tickets like this moving forward.

// Abbrev tests from Ruby stdlib docs
// https://ruby-doc.org/stdlib-2.6.3/libdoc/abbrev/rdoc/Abbrev.html
#[cfg(test)]
mod tests {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 these are excellent thank you.

@@ -217,6 +217,7 @@ def inspect
runner.register(Spec.new('library', 'monitor'))
runner.register(Spec.new('library', 'stringscanner'))
runner.register(Spec.new('library', 'uri'))
runner.register(Spec.new('library', 'abbrev'))
Copy link
Member

@lopopolo lopopolo Dec 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this list is alphabetized

@lopopolo lopopolo merged commit 24aa683 into artichoke:master Dec 8, 2019
@lopopolo lopopolo added the A-ruby-stdlib Area: Ruby Standard Library packages. label Dec 8, 2019
@lopopolo
Copy link
Member

lopopolo commented Dec 8, 2019

@zaccari since issue GH-74 was written, there have been some changes to the Artichoke build pipeline to enable codegen for pure Ruby stdlib packages from upstream Ruby. URI uses this pipeline today:

pub mod uri {
//! Ruby URI package, implemented with embedded sources from MRI 2.6.3.
// See scripts/auto_import/.
include!(concat!(env!("OUT_DIR"), "/src/generated/uri.rs"));
}

The rest of the existing stdlib ports in Artichoke exist mostly as legacy from the artichoke/ferrocarril#85 days.

Moving forward, I'd like stdlib implementations to use this build pipeline if possible. Artichoke maintains a fork of Ruby 2.6.3 that we push fixes to to make these stdlib packages work with the Artichoke and mruby Runtime :https://github.com/artichoke/ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ruby-stdlib Area: Ruby Standard Library packages.
Development

Successfully merging this pull request may close these issues.

Implement standard library package abbrev
2 participants