Add constant definition APIs to artichoke-core #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DefineConstant` exposes APIs for defining global constants as well as constants on class or module values. Use them in extn global constants and `Random::DEFAULT`. This commit removes the macro-based const definition approach in `extn::init`.
lopopolo
added
B-mruby
A-core
lopopolo
added a commit
that referenced
this pull request
Feb 22, 2020
`Float` and `Regexp` both define constants by string formatting `i64`s and `f64`s into a code string with `format!` and evaling it on the interpreter. This is not ideal. GH-526 added constant definition APIs to `artichoke-core` and implemented them for `artichoke-backend`. This commit wires it up in `extn`. The resulting code has more localized failures - errors are reported on the granularity of defining a single constant. The constant values are converted into proper `Value`s directly from their native Rust form. See also GH-27, the issue referenced by both of the TODOs (the TODO in `float.rs` refers to the issue number from lopopolo/ferrocarril before it was migrated to the artichoke/artichoke repo).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefineConstantexposes APIs for defining global constants as well asconstants on class or module values.
Use them in extn global constants and
Random::DEFAULT. This commitremoves the macro-based const definition approach in
extn::init.Related to GH-442.
Fixes GH-27.