Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize encode for empty input by hardcoding the result #135

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

lopopolo
Copy link
Member

Benches

boba::encode/empty      time:   [45.861 ns 46.337 ns 46.890 ns]
                        change: [-15.461% -13.929% -12.685%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild
boba::encode/1234567890 time:   [93.673 ns 94.156 ns 94.667 ns]
                        change: [-2.8358% -0.9728% +0.8215%] (p = 0.33 > 0.05)
                        No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
  2 (2.00%) high mild
  3 (3.00%) high severe
boba::encode/Pineapple  time:   [90.281 ns 90.577 ns 90.895 ns]
                        change: [+0.2774% +1.5987% +2.9150%] (p = 0.01 < 0.05)
                        Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
  4 (4.00%) high mild
  2 (2.00%) high severe
boba::encode/emoji      time:   [146.38 ns 146.92 ns 147.50 ns]
                        change: [-1.2052% -0.0792% +1.2912%] (p = 0.92 > 0.05)
                        No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
  3 (3.00%) high mild
  4 (4.00%) high severe

@lopopolo lopopolo added A-performance Area: Performance improvements and optimizations. A-encode Area: Core encoder implementation. labels Mar 27, 2022
@lopopolo lopopolo merged commit 025c58f into trunk Mar 27, 2022
@lopopolo lopopolo deleted the lopopolo/optimize-encode-empty branch March 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-encode Area: Core encoder implementation. A-performance Area: Performance improvements and optimizations.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant