Check and respect token.payload.iss #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreystone
reviewed
Jun 27, 2018
test/fixtures/oidc.json
Outdated
| @@ -81,21 +81,21 @@ | |||
| "code_challenge_methods_supported": [ | |||
| "S256" | |||
| ], | |||
| "introspection_endpoint": "https://authentic.articulate.com/v1/introspect", | |||
| "introspection_endpoint": "https://dev-939480.oktapreview.com/oauth2/default/v1/introspect", | |||
There was a problem hiding this comment.
Do we want real URLs in here?
There was a problem hiding this comment.
I had to match the url in the jwt, which is signed. But I was able to sign a different jwt with a bad iss, so if you'd like I can make a fake url for the "real" jwt, too.
mgreystone
approved these changes
Jun 27, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to respect the
payload.issin JWT's so thatauthenticcan validate tokens supplied by any issuer, not just one. But letting folks supply their ownisswithout verification is problematic, so a safer approach is to whitelist theissvalues we want to respect. This PR replaces the previousoidcUrioption with anissWhitelistoption, which is an array of uri's, rather than a single uri.Note: This is a breaking change, so an appropriate semver bump is required before publishing.
to test: