Change default severity for handled errors to be error and allow options to be passed in #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons to be passed in
mgreystone
approved these changes
Sep 26, 2019
index.js
Outdated
| } | ||
|
|
||
| if (notifiable(err)) { | ||
| const options = mergeDeepRight({ metaData, severity: 'error' }, opts) |
There was a problem hiding this comment.
I know we're struggling with under-reported errors... but should we really default to error at this level? Should catchAndCry specify its severity: 'error'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
notifyto actually support the passing of options, also bugsnag sets the default severity for handled errors towarning, really a handled error is still an error.{ severity: 'warning' }should be passed in if something really is just a warning.