Skip to content
This repository has been archived by the owner on Jun 14, 2021. It is now read-only.

Feature/network zones #201

Merged
merged 9 commits into from Jul 3, 2019
Merged

Conversation

marnas
Copy link
Contributor

@marnas marnas commented Jul 1, 2019

I implemented a resource that will allow to create and manage network zones.
API Reference: https://developer.okta.com/docs/reference/api/zones/

Please note that the "Dynamic" feature needs to be enabled in your Okta in order to work. To get this it should be enough to get in touch with their support team, as it seems to be an early access feature.

Also please note that I'm way far from being a GO developer, I'm open to any suggestion.

Copy link
Contributor

@quantumew quantumew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this, really appreciate the contribution. There are a few comments, let me know if you want me to help out with any of it.

okta/resource_network_zone_test.go Show resolved Hide resolved
okta/resource_network_zone.go Outdated Show resolved Hide resolved
okta/resource_network_zone.go Outdated Show resolved Hide resolved
Copy link
Contributor

@quantumew quantumew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this to develop, wrap it up, and release it. Thanks!

@quantumew quantumew changed the base branch from master to develop July 3, 2019 15:41
@quantumew quantumew merged commit 4f1e3ed into articulate:develop Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants