[BigQuery] Specify column names for Append (#739)

artie-labs · Jun 18, 2024 · 9eef6e5 · 9eef6e5
1 parent 0d649bd
commit 9eef6e5
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/clients/bigquery/bigquery.go b/clients/bigquery/bigquery.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log/slog"
 	"os"
+	"strings"
 
 	"cloud.google.com/go/bigquery"
 	"cloud.google.com/go/bigquery/storage/managedwriter"
@@ -67,9 +68,14 @@ func (s *Store) Append(tableData *optimization.TableData, useTempTable bool) err
 		return fmt.Errorf("failed to append: %w", err)
 	}
 
-	if _, err = s.Exec(
-		fmt.Sprintf(`INSERT INTO %s SELECT * FROM %s`, tableID.FullyQualifiedName(), temporaryTableID.FullyQualifiedName()),
-	); err != nil {
+	query := fmt.Sprintf(`INSERT INTO %s (%s) SELECT %s FROM %s`,
+		tableID.FullyQualifiedName(),
+		strings.Join(sql.QuoteIdentifiers(tableData.ReadOnlyInMemoryCols().GetColumnsToUpdate(), s.Dialect()), ","),
+		strings.Join(sql.QuoteIdentifiers(tableData.ReadOnlyInMemoryCols().GetColumnsToUpdate(), s.Dialect()), ","),
+		temporaryTableID.FullyQualifiedName(),
+	)
+
+	if _, err = s.Exec(query); err != nil {
 		return fmt.Errorf("failed to insert data into target table: %w", err)
 	}