Move defer up

artie-labs · Jun 18, 2024 · ab80577 · ab80577
1 parent d39e66f
commit ab80577
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/clients/bigquery/bigquery.go b/clients/bigquery/bigquery.go
@@ -55,6 +55,9 @@ func (s *Store) Append(tableData *optimization.TableData, useTempTable bool) err
 	// For now, we'll need to append this to a temporary table and then append temporary table onto the target table
 	tableID := s.IdentifierFor(tableData.TopicConfig(), tableData.Name())
 	temporaryTableID := shared.TempTableID(tableID)
+
+	defer func() { _ = ddl.DropTemporaryTable(s, temporaryTableID, false) }()
+
 	err := shared.Append(s, tableData, types.AdditionalSettings{
 		UseTempTable: true,
 		TempTableID:  temporaryTableID,
@@ -64,8 +67,6 @@ func (s *Store) Append(tableData *optimization.TableData, useTempTable bool) err
 		return fmt.Errorf("failed to append: %w", err)
 	}
 
-	defer func() { _ = ddl.DropTemporaryTable(s, temporaryTableID, false) }()
-
 	if _, err = s.Exec(
 		fmt.Sprintf(`INSERT INTO %s SELECT * FROM %s`, tableID.FullyQualifiedName(), temporaryTableID.FullyQualifiedName()),
 	); err != nil {