[dml] Remove buildColumnsUpdateFragment argument
#556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
commented
May 3, 2024
| @@ -157,7 +157,7 @@ func (m *MergeArgument) GetParts() ([]string, error) { | |||
| // UPDATE | |||
| fmt.Sprintf(`UPDATE %s as c SET %s FROM %s as cc WHERE %s%s AND COALESCE(cc.%s, false) = false;`, | |||
| // UPDATE table set col1 = cc. col1 | |||
| m.TableID.FullyQualifiedName(), buildColumnsUpdateFragment(columns, m.Dialect, true), | |||
| m.TableID.FullyQualifiedName(), buildColumnsUpdateFragment(columns, m.Dialect), | |||
There was a problem hiding this comment.
Delete column marker was removed https://github.com/artie-labs/transfer/pull/556/files#diff-e297e1a797fbb22e7fc1b6ee5ccd51774aa48d89253950cd1e6642ced703e334R144
nathan-artie
commented
May 3, 2024
| @@ -261,7 +261,7 @@ WHEN NOT MATCHED AND IFNULL(cc.%s, false) = false THEN INSERT (%s) VALUES (%s);` | |||
| // Delete | |||
| m.Dialect.QuoteIdentifier(constants.DeleteColumnMarker), | |||
| // Update | |||
| m.Dialect.QuoteIdentifier(constants.DeleteColumnMarker), idempotentClause, buildColumnsUpdateFragment(m.Columns.GetColumns(), m.Dialect, true), | |||
| m.Dialect.QuoteIdentifier(constants.DeleteColumnMarker), idempotentClause, buildColumnsUpdateFragment(columns, m.Dialect), | |||
There was a problem hiding this comment.
nathan-artie
commented
May 3, 2024
| @@ -326,7 +326,7 @@ WHEN NOT MATCHED AND COALESCE(cc.%s, 1) = 0 THEN INSERT (%s) VALUES (%s);`, | |||
| // Delete | |||
| m.Dialect.QuoteIdentifier(constants.DeleteColumnMarker), | |||
| // Update | |||
| m.Dialect.QuoteIdentifier(constants.DeleteColumnMarker), idempotentClause, buildColumnsUpdateFragment(columns, m.Dialect, true), | |||
| m.Dialect.QuoteIdentifier(constants.DeleteColumnMarker), idempotentClause, buildColumnsUpdateFragment(columns, m.Dialect), | |||
There was a problem hiding this comment.
Tang8330
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing
skipDeleteColtobuildColumnsUpdateFragment, we'll just pass a slice of columns that already has the delete column marker removed.