Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifying APPEND #678

Merged
merged 1 commit into from
May 15, 2024
Merged

Simplifying APPEND #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions clients/shared/append.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,11 @@ func Append(dwh destination.DataWarehouse, tableData *optimization.TableData, op
return fmt.Errorf("failed to get table config: %w", err)
}

if opts.ShouldExcludeDeletedColumn {
tableData.InMemoryColumns().DeleteColumn(constants.DeleteColumnMarker)
}

// We don't care about srcKeysMissing because we don't drop columns when we append.
_, targetKeysMissing := columns.Diff(
tableData.ReadOnlyInMemoryCols(),
tableConfig.Columns(),
false,
tableData.TopicConfig().SoftDelete,
tableData.TopicConfig().IncludeArtieUpdatedAt,
tableData.TopicConfig().IncludeDatabaseUpdatedAt,
tableData.Mode(),
Expand Down
4 changes: 0 additions & 4 deletions lib/destination/types/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,4 @@ type MergeOpts struct {

type AdditionalSettings struct {
AdditionalCopyClause string

// ExcludeDeletedColumn - Reader uses this as part of the initial backfill. Customers that have soft deleted enabled should
// have the column `__artie_deleted` = false.
ShouldExcludeDeletedColumn bool
}